kc0bfv
commented
3 years ago Thanks! I am incorporating this stuff - maybe more than you intended... Not sure - but it kept including your pushes to your master, so I kept looking at them.
My Notes:
Take:
- d19ebba
- 889f5d4
- 1447885
- 784aaa2
Not taking:
- be8ee28 - I want to keep the current aesthetic
- 03630d9 - Want to keep current aesthetic - but taxonomy support might be a good addition later, and while I like the image caching change I think I will still need things in resources to do column balancing, and it's a pretty complicated feature for users to use...
- 1f44e9d - tied tightly to 03630d9
- 927c6d0 - tied to 03630d9 I think
- ebd085bc
- 2c98f83 - we'll just get it when it's incorporated
- 79faa3f - tied to earlier
Will do next:
- Check the other spots around that js quotes problem in static/assets /js/main.js, convert tabs to spaces
- Minify and fingerprint via pipes more things
- Walk back some of the new frontmatter content
Added js quotes around download label. This is needed if the file name contains spaces.
This change looks more dramatic than necessary because the original mixed tabs and spaces. The functional change in this diff is easy to miss: 2 single quotes on lines 292 and 294.