search

kc9wwh / macOSUpgrade

Workflow for doing in-place upgrades.
Other
418 stars 103 forks source link

macOS Mojave upgrade fails due to lack of space even though it passed the 15GB system check #117

Closed adammartin253 closed 5 years ago

adammartin253 commented 5 years ago

Came across a Mac that had about 17GB of free space so it made it past the pre-check but once it began the actual in-place upgrade it fails to complete due to lack of storage space.

I removed a few GB to get to 21GB free and tried again. This time I was successful. To avoid this, I am suggesting to change the following parameter on https://github.com/kc9wwh/macOSUpgrade/blob/e193c61d83b51e1d0d89a6b93156e25f4b1d9a3c/macOSUpgrade.sh#L217, https://github.com/kc9wwh/macOSUpgrade/blob/e193c61d83b51e1d0d89a6b93156e25f4b1d9a3c/macOSUpgrade.sh#L226 and https://github.com/kc9wwh/macOSUpgrade/blob/e193c61d83b51e1d0d89a6b93156e25f4b1d9a3c/macOSUpgrade.sh#L377 are as so:

Check if free space > 20GB

if [[ ${freeSpace%.*} -ge 20000000000 ]]; then

/Library/Application\ Support/JAMF/bin/jamfHelper.app/Contents/MacOS/jamfHelper -windowType utility -title "$title" -icon "$icon" -heading "Requirements Not Met" -description "We were unable to prepare your computer for $macOSname. Please ensure you are connected to power and that you have at least 20GB of Free Space.
kenchan0130 commented 5 years ago

@adammartin253 Thank you for your feedback. I will fix this issue and I want some more information.

Please tell us which version you upgraded to which version.

adammartin253 commented 5 years ago

Mac OS X 10.11.6 to macOS Mojave 10.14.4

Adam Martin HBO Desktop Engineer – Media Technology & Information Services

On Jun 10, 2019, at 7:57 PM, Tadayuki Onishi notifications@github.com<mailto:notifications@github.com> wrote:

External Email received from: noreply@github.commailto:noreply@github.com

@adammartin253https://github.com/adammartin253 Thank you for your feedback. I will fix this issue.

Please tell us which version you upgraded to which version.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/kc9wwh/macOSUpgrade/issues/117?email_source=notifications&email_token=AF7XY275LTX3WRAWYOGAFFLPZ4ICFA5CNFSM4HVAG54KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLZMPA#issuecomment-500667964, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AF7XY2YEPFRZZ6RGUFOWK2DPZ4ICFANCNFSM4HVAG54A.

kenchan0130 commented 5 years ago

@adammartin253 I would say this issue was fixed. If you still have problems, please reopen.

adammartin253 commented 5 years ago

Looks good to me

Sent from my iPhone

On Jun 12, 2019, at 11:44 PM, Tadayuki Onishi notifications@github.com<mailto:notifications@github.com> wrote:

External Email received from: noreply@github.commailto:noreply@github.com

@adammartin253https://github.com/adammartin253 I would say this issue was fixed. If you still have problems, please reopen.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/kc9wwh/macOSUpgrade/issues/117?email_source=notifications&email_token=AF7XY27UBCVQDYDDY3YDXM3P2HUETA5CNFSM4HVAG54KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXSV6AY#issuecomment-501571331, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AF7XY23TZOKLMU4YTV2H3QLP2HUETANCNFSM4HVAG54A.