search

kc9wwh / macOSUpgrade

Workflow for doing in-place upgrades.
Other
418 stars 103 forks source link

Support OS update is frozen if there are multiple startosinstall processes #123

Closed kenchan0130 closed 4 years ago

kenchan0130 commented 5 years ago

Purpose

Fix https://github.com/kc9wwh/macOSUpgrade/issues/102

Plan

I have 2 plan.

Plan 1: Kill processes from previous run before running launch agent and startosinstall. Plan 2: Exit this script if exist some processes.

I select Plan 1. This is because I thought that it was difficult for the user to delete the process independently. By making this selection, OS upgrade will be interrupted, thus allowing the risk of failure. This is open to discussion.

kenchan0130 commented 5 years ago

If it is safe to use plan 2 is adopted. I am looking for opinions.

adammartin253 commented 5 years ago

Plan 1 seems more logical to me because plan 2 requires that the end user must manually restart the policy correct? Whereas Plan 1 looks for conflicting processes before kicking off the script and removes them to avoid issues.

kenchan0130 commented 5 years ago

@adammartin253 Thank you for your response. Do you think that the risk of plan1 is acceptable or nonexistent? I have honesty no confidence.

adammartin253 commented 5 years ago

It is hard to say. I think the best way to determine the risk is to manually do what is intended to be done with Plan 1 if/when multiple instances occur and see if it succeeds. I am about to deploy the latest script to about 600 Macs by the end of July so I can test as things come up.

taniguti commented 5 years ago

Please resolve conflicts.

kenchan0130 commented 5 years ago

@taniguti I fixed conflicts