search

kc9wwh / macOSUpgrade

Workflow for doing in-place upgrades.
Other
419 stars 102 forks source link

eraseintall condition has changed after 10.14 or later #124

Open taniguti opened 5 years ago

taniguti commented 5 years ago

startosinstall of macoS 10.14 installer or later, its usage says as follows,

--eraseinstall, (Requires APFS) Erase all volumes and install to a new one. Optionally specify the name of the new volume with --newvolumename.
--newvolumename, the name of the volume to be created with --eraseinstall.
--preservecontainer, preserves other volumes in your APFS container when using --eraseinstall.

So, eraseinstall won't work with Mac computer which has HFS Plus boot volume if user try to upgrade from 10.13 or earlier to 10.14 or later.

Consider on preservecontainer option handling. On current implementation, 0 means not erase and 1 means erase. So I think we could use more numeric for this option. 2 means erase startup disk but preserve another container

kenchan0130 commented 5 years ago

https://github.com/MLBZ521/install_macOS/blob/f1b21fdbcb57d1ba7da8e2b0772ff2aef99fd6b2/install_macOS.sh#L70-L102 This is very helpful.