search

kc9wwh / macOSUpgrade

Workflow for doing in-place upgrades.
Other
418 stars 103 forks source link

Make OS agnostic #34

Closed patgmac closed 6 years ago

patgmac commented 6 years ago

Changed instances of “macOS Sierra” to $macOSname, which is specified with $7 in the JSS.

kc9wwh commented 6 years ago

Hey @patgmac!

Thanks for this. Just got back into the office and reviewing it everything looks good. My only concern is in the heading variable we are calling macOSname before it is declared. Did you notice any issues in this while testing?

Also, what are your thoughts on instead of declaring macOSname and title variables that we derive them from the OSInstaller variable?

patgmac commented 6 years ago

I did not have an issue referencing macOSname early since it's not actually being called upon yet.

Getting macOSname and title from OSInstaller is not a bad idea. I'll see what I can do.

patgmac commented 6 years ago

@kc9wwh should be read to go now.

kc9wwh commented 6 years ago

Looks good, awesome work!