search

kc9wwh / macOSUpgrade

Workflow for doing in-place upgrades.
Other
418 stars 103 forks source link

Wrong value in plist #61

Closed taniguti closed 5 years ago

taniguti commented 6 years ago

Hi,

I think it must be integer, mount of seconds but there is a string 'Aqua'.

https://github.com/kc9wwh/macOSUpgrade/blob/8e61fd1c75f0566abb4b62cf7a7360eabcd1c174/macOSUpgrade.sh#L302-L303

I'm not sure how much mount of time is reasonable. But how about 600 or so.

Best regards,

taniguti commented 5 years ago

This will be fixed by @scifiman PR #67. thanks

kc9wwh commented 5 years ago

This was actually what was expected in 10.12 and worked in my 10.13 testing. https://github.com/kc9wwh/macOSUpgrade/issues/13#issuecomment-350719156

But I honestly don't know how to reverse engineer what Apple is doing here, so if it works in testing I'm willing to accept the PR. Hopefully will have time this week to review all the code changes and test.

kc9wwh commented 5 years ago

Thank you @taniguti for your help! This is actually very helpful and I love it! :)