kc9wwh / macOSUpgrade

Workflow for doing in-place upgrades.
Other
418 stars 102 forks source link

Changes and Fixes #67

Closed scifiman closed 6 years ago

scifiman commented 6 years ago

Fixed issues identified by shellcheck.net Added --agreetolicense to the startosinstall command. Added variable validChecksum to help break out of the download loop. Changed the Timeout value in the plist generation from "Aqua" to 300. Changed some commands to use absolute paths as noted by @kenchan0130.

Also, there is a section that checks OS version. First it checks against 10.12, then checks if the OS is less than 10.13.4. Is this something that needs to be continually updated with new OS versions? Finally, it seems this script does not work if some of the parameters are not given by the Jamf script. I feel this is something that could benefit from default values and then be overridden by the parameters if needed.

kc9wwh commented 6 years ago

@scifiman Thank you for your help. As for your question, yes. When 10.13 was released they switched the verbiage of how Free Space was labeled, but then in 10.13.4 they changed it back to was it was previous to 10.13, couldn't make up their mind I guess ¯_(ツ)_/¯