search

kc9wwh / macOSUpgrade

Workflow for doing in-place upgrades.
Other
418 stars 103 forks source link

improve: execute startosinstall in safe #73

Closed taniguti closed 5 years ago

taniguti commented 5 years ago

Hi,

kc9wwh commented 5 years ago

@taniguti I'm okay with the mkdir -p change, but nohup I am not as familiar with, so I have a few questions...

Thank you for your continued efforts to make this script more stable!

taniguti commented 5 years ago

@kc9wwh

Sorry my lazy response...

On nohup.

The nohup won't interfere with startosinstall. It will protect executing startosinstall from signal of out side.

macOS 10.10 has nohup. Maybe macOS 10.9 and earlier also has it.

vmac03:~ ladmin$ sw_vers -productVersion; which nohup
10.10.5
/usr/bin/nohup

Yes. in that case nohup will create output file in '/Applications'. It's not good. I will add code nohup put into /var/log/startosintall.log.

I checked this script on macOS 10.10 with High Sierra installer. And I got error on agreetolicense. I also look further what happens on that condition.

taniguti commented 5 years ago

@kc9wwh

My virtual machine farm was too old to test to upgrade from 10.10. So I rebuilt it. But I took too much time. Anyway I tested current PR version of script following conditions and they worked as I expected. nohup creates /var/log/startosintall.log but installer will clean up files in /var/log. So after updated OS, the file /var/log/startosintall.log will not exist there.