search

kc9wwh / macOSUpgrade

Workflow for doing in-place upgrades.
Other
418 stars 103 forks source link

Do failed script when some requirements are not met. #80

Closed kenchan0130 closed 5 years ago

kenchan0130 commented 5 years ago

The OS upgrade policy will often be "Once per computer" of Execution Frequency in jamf policy.

So when some requirements are not met, I think that it is better to expect this script to fail.

kenchan0130 commented 5 years ago

Currently, we can not run the policy again when the script is failed with "Once per computer" of Execution Frequency.

https://www.jamf.com/jamf-nation/feature-requests/827/policy-execution-once-per-computer-if-successful

But I think that this patch is convenient because we can see logs about script failed.

kc9wwh commented 5 years ago

@kenchan0130 - Have you tested this via Self Service with a failure? The reason it was this way is because in the 9 series Self Service would have throw a couple additional failure prompts which really deterred from the end-user experience.

I just want to ensure that is maintained and if so, I have no problem merging this.

Thank you for all your work on this!

kenchan0130 commented 5 years ago

Have you tested this via Self Service with a failure?

Yes, I have. It seems that this script was failed and the policy looked success.

I don't familiar with the 9 series because I am always using version 10.x Self Service.