Get the list of equipments right after remodeling

kcaa commented 9 years ago

This should be possible as the client does it. That said the priority is not that high as it will be refreshed when getting back to the port.

kcaa commented 9 years ago

Not reproducible? This was once an issue on Linux with Dartium but no problem on Windows with compiled (dart2js-ed) client.

kcaa commented 9 years ago

Still reproducible on Linux. Confirmed with Ashigara Kai-2.

kcaa commented 9 years ago

Mystery explained:

/api_req_kaisou/remodeling happens first. This just delivers whether it was successful or not.
/api_get_member/ship3 triggers next. This contains the list of equipment IDs for the new items. But at this moment the EquipmentList doesn't contain entries for them. Still, the client can receive ShipList with an incomplete information before the next event happends:
/api_get_member/slot_item occurs lastly. This contains the entries for the new items.

Thus, if the client request ShipList before /api_get_member/slot_item happens (1 seconds delay after /api_get_member/ship3), this issue occurs. If there is enough update interval, this may not happen thanks to REFERENCED_OBJECTS priority list.

This can be fixed by re-updating the Ship's equipment list (on the client) when received EquipmentList.

kcaa commented 9 years ago

That said, the priority is still low. Worth considering the trade-off of supporting this case v.s. the code complexity and CPU resource consumption.

kcaa / kcaa

Get the list of equipments right after remodeling #213