kcamcam / vscode_dark_modern.zed

VS Code Dark Modern theme for Zed
MIT License
6 stars 2 forks source link

C++ items color not fully matching #12

Open yaymalaga opened 1 month ago

yaymalaga commented 1 month ago

Hi, first at all thanks for the theme, I'm really enjoying Zed with it!

I'm doing some C++ right now and noticed some of the keywords are not colored at all or they have the wrong colors. I'm not entirely sure if this is Zed's issue or the theme itself though, so just posting it here first.

As you can see below, the results are pretty close! However there is some missing stuff:

Another difference is the brackets & curly brackets coloring, but I think that needs to be implemented in Zed's side first.

Screenshot from 2024-08-10 16-39-02

kcamcam commented 3 weeks ago

@yaymalaga thanks for sharing!

I think most of those changes can be adjusted directly in our theme. I have noticed there are some discrepancies in the colours as well.

I'll try to get to it in the coming weeks but until then anyone seeing this can feel free to tackle to if they are interested.

juliovata commented 2 weeks ago

Hello @kcamcam!

I did some tinkering and it seems like there aren't enough options in the json file to fully match VS Code's theme? Examples: Primitive types should be #569CD6 but are currently #4EC9B0. Its not enough to just change the types entry in the json file because doing so would make user defined types the wrong color (they are #4EC9B0 in VS Code). To get if, else, switch, case, return, #include, #define colored correctly, the keyword color should be changed to something like #C57C9C but then that would make the volatile, static, and extern keywords the wrong color (they are both #569CD6 in VS Code).