kcamcam / vscode_dark_modern.zed

VS Code Dark Modern theme for Zed
MIT License
6 stars 2 forks source link

Instructions for replicating font settings #4

Open MatthewScholefield opened 1 month ago

MatthewScholefield commented 1 month ago

In case anyone else wants to get the font rendering as close to VSCode as possible, these are the settings I arrived upon that I found matched closest:

"ui_font_size": 16,
"buffer_font_size": 13.7037024497986,
"buffer_font_family": "Droid Sans Mono",
"buffer_font_weight": 100,
"buffer_line_height": {
    "custom": 1.35
},

And I made sure to install the Droid Sans Mono font on my system and restart Zed to get it to pick it up. For Linux:

mv DroidSansMono.ttf ~/.local/share/fonts/
rm -r ~/.cache/fontconfig/
fc-cache -r
kcamcam commented 1 month ago

@MatthewScholefield thanks for providing the example that worked for you. I think this would make a good addition to the theme if you want to open a pull request it would be most welcome. Excluding the font family since it requires the font to be installed separately.

2zqa commented 1 month ago

I would also propose maybe adding "current_line_highlight": "none", because VS Code line highlight are two very subtle lines, whereas Zed uses a complete line highlight. This does however reduce visibility of where your cursor is.

MatthewScholefield commented 1 month ago

Yeah. @2zqa Curious, do you think no line highlight is better than having a very subtle line highlight color like that used in the new proposed colors?

Personally I think having a really subtle background color change for the line highlight feels similar to VSCode's top and bottom thin line indicators.

2zqa commented 1 month ago

That's a good one, I didn't even consider that option. Good idea.

2zqa commented 1 month ago

Perhaps we can add this to the README.md. @MatthewScholefield, do you want to create a PR for this?