kcamcam / vscode_dark_modern.zed

VS Code Dark Modern theme for Zed
MIT License
6 stars 2 forks source link

Use generated values #8

Closed 2zqa closed 1 month ago

2zqa commented 1 month ago

Resolves #6

2zqa commented 1 month ago

I didn't blindly copy the entire JSON generated. I've included the raw generated JSON file that I used. You can diff this file against my proposed changes to see which values I left out and which other changes I made.

generated.json

Actually, I'll include the diff here as well for convenience:

Diff (click to expand) ```diff --- generated.json 2024-07-22 22:05:05.417152568 +0200 +++ my-edit.json 2024-07-22 22:07:43.870956794 +0200 @@ -4,11 +4,10 @@ "author": "kcamcam", "themes": [ { - "name": "", + "name": "VSCode Dark Modern", "appearance": "dark", "style": { "background.appearance": "opaque", - "accents": [], "border": "#2b2b2b", "border.variant": "#2b2b2b", "border.focused": "#0078d4", @@ -45,7 +44,7 @@ "tab_bar.background": "#181818", "tab.inactive_background": "#181818", "tab.active_background": "#1f1f1f", - "search.match_background": null, + "search.match_background": "#623315", "panel.background": "#181818", "panel.focused_border": null, "pane.focused_border": null, @@ -59,8 +58,8 @@ "editor.background": "#1f1f1f", "editor.gutter.background": "#1f1f1f", "editor.subheader.background": null, - "editor.active_line.background": null, - "editor.highlighted_line.background": null, + "editor.active_line.background": "#212121", + "editor.highlighted_line.background": "#212E3A", "editor.line_number": "#6e7681", "editor.active_line_number": "#cccccc", "editor.invisible": null, @@ -99,10 +98,10 @@ "terminal.ansi.bright_white": "#e5e5e5", "terminal.ansi.dim_white": null, "link_text.hover": "#4daafc", - "conflict": null, + "conflict": "#d16969", "conflict.background": null, "conflict.border": null, - "created": "#2ea043", + "created": "#73c991", "created.background": null, "created.border": null, "deleted": "#f85149", @@ -117,13 +116,13 @@ "hint": "#969696", "hint.background": null, "hint.border": null, - "ignored": null, + "ignored": "#8c8c8c", "ignored.background": null, "ignored.border": null, "info": "#3794ff", "info.background": null, - "info.border": null, - "modified": "#0078d4", + "info.border": "#1E1E1E", + "modified": "#E2C08D", "modified.background": null, "modified.border": null, "predictive": null, @@ -141,7 +140,48 @@ "warning": "#cca700", "warning.background": null, "warning.border": null, - "players": [], + "players": [ + { + "cursor": "#5AC1FEFF", + "background": "#5AC1FEFF", + "selection": "#5AC1FE3D" + }, + { + "cursor": "#39BAE5FF", + "background": "#39BAE5FF", + "selection": "#39BASE53D" + }, + { + "cursor": "#FE8F40FF", + "background": "#FE8F40FF", + "selection": "#FE8f403D" + }, + { + "cursor": "#D2A6FEFF", + "background": "#D2A6FEFF", + "selection": "#D2A6FE3D" + }, + { + "cursor": "#95E5CBFF", + "background": "#95E5CBFF", + "selection": "#95E5CB3D" + }, + { + "cursor": "#EF7177FF", + "background": "#EF7177FF", + "selection": "#EF71773D" + }, + { + "cursor": "#FEB454FF", + "background": "#FEB454FF", + "selection": "#FEB4543D" + }, + { + "cursor": "#AAD84CFF", + "background": "#AAD84CFF", + "selection": "#AAD84C3D" + } + ], "syntax": { "attribute": { "color": "#9CDCFE", ```
2zqa commented 1 month ago

I think we might be getting some overlap from VS Code Dark+ and VS Code Dark

That's no surprise, since Dark Modern is based upon it

some of the colours being added are still off

Are you referring to missing colors, colors we manually changed or generated colors?