kcamcam / vscode_dark_modern.zed

VS Code Dark Modern theme for Zed
MIT License
6 stars 2 forks source link

Track manual changes with CUSTOMIZATIONS.md #9

Closed 2zqa closed 1 month ago

2zqa commented 1 month ago

Like described in my comment here (https://github.com/kcamcam/vscode_dark_modern.zed/issues/2#issuecomment-2243752200), I have tried my own hand at creating a repository which has both Modern Dark and Modern Light themes included. I adopted the idea of tracking changes in CUSTOMIZATIONS.md, because this would allow us to track which values are generated by the importer and which ones are manually created.

Pros:

Cons:

So if you're not sold on the idea, feel free to close this issue.

kcamcam commented 1 month ago

Thanks for the issue @2zqa.

I agree with the pros and cons. Ultimately I think that the extra cost in maintainability outweighs the mentioned pros.

Let's leave the issue open to see if anyone else has an opinion or other ideas.

2zqa commented 1 month ago

It's been two weeks, I'll go ahead and close this. Looking back at this issue, it's probably not worth it. Plus, git blame can be used in dire situations.