search

kcat / openal-soft

OpenAL Soft is a software implementation of the OpenAL 3D audio API.
Other
2.22k stars 536 forks source link

compilation fails on ppc64el with Altivec SIMD since 1.24.0 #1061

Closed smcv closed 2 days ago

smcv commented 3 days ago

Version 1.24.0 doesn't build successfully on Debian's ppc64el (little-endian 64-bit POWER) architecture:

/<<PKGBUILDDIR>>/common/pffft.cpp: In function ‘void {anonymous}::uninterleave2(v4sf, v4sf, v4sf&, v4sf&)’:
...
/<<PKGBUILDDIR>>/common/pffft.cpp:130:12: error: ‘tmp’ was not declared in this scope; did you mean ‘tm’?
  130 |     out1 = tmp;

I think this is a regression from commit 8032217 "Avoid some unnecessary tmp vars" which looks like there's a mistake in the Altivec implementation. I'll ask the Debian ppc64el/powerpc/ppc64 ports team if they can submit a PR for a fixed, tested Altivec code path.

(Debian bug 1087828, full build log)

kcat commented 3 days ago

Looks like I missed that line that should have been removed. Commit 62b33d388685a8feb6505478dd497c392110884d should fix it.

jbicha commented 2 days ago

Yes, that fixed this issue