search

kcat / openal-soft

OpenAL Soft is a software implementation of the OpenAL 3D audio API.
Other
2.19k stars 528 forks source link

fpu_ctrl: exclude non i386 archs from SSE #926

Open es20490446e opened 1 year ago

es20490446e commented 1 year ago

To: core/fpu_ctrl.cpp

I have seen a place that applies this patch: mxcsr.patch

Do you think this is something that could be included here?

If so I can make a pull request.

es20490446e commented 1 year ago

This is for compatibility with the Russian Elbrus2k CPU architecture.

kcat commented 1 year ago

I'm curious what the failure actually is. Why SSE is detected and HAVE_SSE is set, but the stmxcsr or ldmxcsr instructions fail. Does GCC not support inline assembly on that architecture, or does it only support the intrinsics and map them to other instructions?

A better option may be to avoid the inline assembly altogether, and optionally enable use of the intrinsics when SSE is available. It'd require moving the SSE calls to a separate function that can enable SSE codegen separate from the enter/leave methods, with those functions only being called when the appropriate CPUCapFlags are set.

es20490446e commented 1 year ago

@stgatilov Do you have any suggestion on this?

kcat commented 1 year ago

Does commit 28ebc90521ca36fce35ea3e298938f2b35a8d79d help any? It tries to avoid the inline assembly and use the intrinsics when SSE is detected at runtime.

es20490446e commented 1 year ago

I personally cannot comment on this, because I wasn't the person creating the patch.

I will ask him to come.

es20490446e commented 1 year ago

Request

stgatilov commented 1 year ago

Elbrus GCC-based compiler supports SSE intrinsics by translating them into Elbrus VLIW instructions. But it does not support x86 assembly, cpuid and other stuff. Thus it defines (or should define) having SSE support, but is not x86.

To be honest, I won't be surprised if some of Elbrus guys already provided some fix for this to master.