kcheng1021 / GaussianPro

[ICML2024] Official code for GaussianPro: 3D Gaussian Splatting with Progressive Propagation
https://kcheng1021.github.io/gaussianpro.github.io/
MIT License
551 stars 36 forks source link

Questions about depth parameter #33

Open XOURTNEY opened 2 months ago

XOURTNEY commented 2 months ago

kcheng1021, Thanks for the amazing work firstly!

I have questions about depth parameter.

  1. When invoking depth propagation, I saw the parameters default are [depth_min, (depth_max-depth_min)/192.0, 192.0, depth_max], I wonder about the meaning of 192?
  2. And there is "depth_max = 20" for default scenes, if I wanna test objects about 10-20cm high, should I turn this dept_max down?
  3. And in Propagation.cpp, there are "params.depth_min = cameras[0].depth_min 0.6f; params.depth_max = cameras[0].depth_max 1.2f;". For things about 10-20cm high, how should I change this number? Thanks!
kcheng1021 commented 2 months ago

Hi, thanks for your recognition!

  1. 192 is a redudant parameter which we used to do some experiments. You can just ignore it. The current code still has some redundancies. We are updating this project and making some optimizations to the CUDA part. There will be another update soon.

  2. Yeah, adjusting depth_max according your data is better. The purpose of setting the maximum depth is to filter out some numerically large outliers during propagation, and for areas where the depth is less than 0, to randomly initialize some new values within the maximum depth range. Therefore, it might be better to adjust according to scale.

  3. You only need to change the depth_max. And it only affects the extreme values.