[Intro to iOS] RottenTomatoes Review

[kchens]

My app is complete, please review. /cc @thecodepath

FYI, hours count time spent on collection view requirement -- which is unfinished and (the changes are) stashed locally.

[codepathreview]

@codepathreview is the best account to mention

[codepathreview]

:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API.

Here's a checklist of things that I'm looking for in this project. You should review the checklist, and make any changes to your project, if necessary.

• Code styling: check out the Ray Wenderlich Swift Style Guide and the Github Swift Style Guide
• Review the properties and methods that you've made public. Your classes should reveal a minimum interface and only expose things that must be used by other classes.
• Consider using SwiftyJSON for easier deserialization of the JSON response.
• When creating a custom cell, make sure never to use imageView, titleLabel, or subtitleLabel. Those are already used by UITableViewCell and using them in your custom cell will cause subtle things to happen such as image views not loading until you click on the cell.
• The images should be downloaded asynchronously. One way to do that was to use AFNetworking, installed via CocoaPods.
• Observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• Next week, we'll cover how to use Auto Layout constraints to implement dynamic height rows and adjust to synopsis of different length.
• kudos for Swift 2.0, there are some distinct differences with 1.2 however so be prepared. And be ready for more fights with Xcode, in particular with major new releases

In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.

-- dirk