- Fixed error when generating cert with argument "--it" should be "-it".

kchristensen / udm-le

Let's Encrypt support for Ubiquiti UniFi OS

MIT License

572 stars 79 forks source link

- Fixed error when generating cert with argument "--it" should be "-it". #1

Closed gtrabanco closed 4 years ago

gtrabanco commented 4 years ago

More features:

Added support to SAN, now you can generate wildcard cert.
Added support with on_boot to make all permanent if you have it installed, check: https://github.com/boostchicken/udm-utilities/tree/master/on-boot-script

Please, test it before merge.

kchristensen commented 4 years ago

Hey! Someone's actually using this, that's cool. Thanks for the PR. I've got a comment or two I'll toss in-line but otherwise this looks good!

gtrabanco commented 4 years ago

One more thing do not know it is important I am using /mnt/data/ssl because on_boot script is the dir that it's using.

gtrabanco commented 4 years ago

Should I do a new PR?

kchristensen commented 4 years ago

You should be able to just fix things and push that commit to this branch to update the PR. :)

kchristensen commented 4 years ago

Oh, you didn't create a branch on your fork, so I'm not 100% sure that'll work, but give it a shot.

gtrabanco commented 4 years ago

Oh, you didn't create a branch on your fork, so I'm not 100% sure that'll work, but give it a shot.

I didn't, sorry I should 😅

kchristensen commented 4 years ago

Thanks for updating that -- I'm going to merge this and commit some stuff tonight to officially switch the path stuff to /mnt/data/ssl as well as some other stuff. Stay tuned!