search

kchristensen / udm-le

Let's Encrypt support for Ubiquiti UniFi OS
MIT License
572 stars 79 forks source link

Document Azure DNS configuration #25

Closed yoannchaudet closed 3 years ago

yoannchaudet commented 3 years ago

Hello 👋,

In this pull request, I am documenting how to use the Azure provider.

I am also proposing to use a single mount folder for additional settings/secrets that is not provider specific. I.e. replace .gcloud and .aws by .secrets (I don't mind about the name). I think it just makes it easier and more generic to configure the other providers Lego supports. Opinion?

I tested these changes on:

Model:       UniFi Dream Machine
Version:     1.8.5.2964

Note: on that new firmware, the cron tab does not seem to persist between reboots. I'll test https://github.com/boostchicken/udm-utilities/tree/master/on-boot-script.

kchristensen commented 3 years ago

The cron stuff has never persisted so that's not new, I use the on-boot-script and it seems to work well.

First off thanks for contributing. Now that people have been adding support for various different providers that can't be configured purely via environment variables I agree that standardizing a directory for credentials of all sorts is a good idea.

I don't think .secrets is a bad name, I propose we leave this issue open for a few days and if anyone has objections or a better name we can discuss. Failing that, I'll merge this and cut a new release documenting the breaking change.

yoannchaudet commented 3 years ago

Thanks for making this project!

The cron stuff has never persisted so that's not new, I use the on-boot-script and it seems to work well.

Gotcha, I was not sure reading the persistence section in the README. I made one last edit there.

kchristensen commented 3 years ago

Well, it's been a few days and I haven't seen any objections so I'm going to merge this and cut a release!