search

kchristensen / udm-le

Let's Encrypt support for Ubiquiti UniFi OS
MIT License
565 stars 79 forks source link

Name.com support added to configuration #61

Closed jebbisson closed 2 years ago

jebbisson commented 2 years ago

Tested out adding the name.com variables and added some comments and instructions around them that I found useful. Overall this worked well and appreciate you putting the scripts together. I did run into the crlf issue when editing in windows and then uploading, oddly only on the second edit and not the first edit.

I also run the hotspot portal but didn't enable the flag at first. Can report that re-running initial with that flag(and experimental bundle enabled) does seem to work. I haven't yet deployed this unit to production so can't confirm 100%.

I am hoping to do that in the next few days so can report on success or updates if something goes wrong.

kchristensen commented 2 years ago

This looks good to me, whenever you're ready I'll give it a merge.

jebbisson commented 2 years ago

Went well in my production tests. Thanks!