search

kcigeospatial / MDOT-SHA-NPDES-Next-Gen

Code and issues related to the MDOT SHA NPDES Project. Project codes: Config = 31, Management = 32.
0 stars 0 forks source link

UG Treatment Pipe Inspection Updates #333

Closed johnshiu closed 5 years ago

johnshiu commented 5 years ago

After reviewing, there are a couple changes I'd like to make to the treatment pipe inspection survey. Please let me know if they are feasible.

  1. TREATMENT_PIPE_ID**: Since users are creating new pipes in AGOL, the FLD_TREATMENT_PIPE feature class generally has null IDs. Therefore, this foreign key will not be populated if they create a new inspection off of those new features. We should add another field for the global ID of the feature so that it can be backpopulated, like we do with IDDE inspections and the FK_FLD_STRUCTUREGUID field. We may also like to add the FK prefix to this field to make it consistent with the latest naming conventions from IDDE.

  2. INSPECTION_STATUS: I'd like to add this field, which we have for BMP and IDDE, so that we can keep FIRM_NAME unchanged when we do submissions and deletions.

**The TREATMENT_PIPE_ID will actually get populated once the inventory field processing script is run. However, there is no guarantee that this will happen before they start collecting inspections against those features.

johnshiu commented 5 years ago

@talllguy, just wanted to check in on this; would these changes be feasible? It significantly affects how the inspection is handled by the scripts, and it's probably best to implement before they start actually collecting data so that the foreign key can be resolved for all the new treatment pipes with null IDs.

talllguy commented 5 years ago

I added a 25 length string field called INSPECTION_STATUS. @johnshiu do you want new inspections to have the value NEW?

johnshiu commented 5 years ago

Yes, a default value of 'NEW' would be helpful, thanks.

talllguy commented 5 years ago

I added the GUID-type field FK_FLD_TP_GUID which will store those incoming Global IDs from the treatment pipe to address point 1 above. This ups the form to v3.3.5. I also dropped the EXIF fields from the photos in this update since none of the underground photos will have GPS.

talllguy commented 5 years ago

@KCI-Ablowers I'm unable to determine which treatment pipes the two that Shane Kelly entered go to. They're on the campus of UMBC which is not near any treatment pipes. Can you find out from Delise which ones they're for?

Also, please notify the field teams to update their UG form to v3.3.5. Let me know when that is complete so I can remove the EXIF fields from the feature.

KCI-Ablowers commented 5 years ago

@talllguy Did the relationship to SWMFAC not come through in the treatment pipe? I'll get in touch with Delise and notify them about the form update.

KCI-Ablowers commented 5 years ago

@talllguy

Also, please notify the field teams to update their UG form to v3.3.5. Let me know when that is complete so I can remove the EXIF fields from the feature.

Did you update the version number in the form? I refreshed and still see v3.3.4.

talllguy commented 5 years ago

yes, it is showing 3.3.5. Try deleting the survey from Survey123 and letting collector redownload it?

KCI-Ablowers commented 5 years ago

I see 3.3.4 in the UG BMP Inspection and no form version in the Underground Treatment Pipe Inspection.

-- I deleted and redownloaded both on my windows version.

talllguy commented 5 years ago

@KCI-Ablowers good catches! I updated the web map to include a button that passes the global ID properly. At the same time I updated the form to show the version under Form Configuration. You'll have to redownload it to see that change.

talllguy commented 5 years ago

Here's andrew's test submittal. Note that the Inspected Treatment Pipe Global ID is populated.

image

talllguy commented 5 years ago

Superseded by #365