kcigeospatial / balt_co_ETL

This will provide a place to track internal issues around the Baltimore County NPDES NCT application ETL.
0 stars 0 forks source link

RestBMPs generate error feature class when there is no selection set #41

Closed leeensminger closed 6 years ago

leeensminger commented 6 years ago

For RestBMPs, it seems the ETL generates the error feature classes _Append_Failure_RESTBMP_p_toRESTBMP and _Append_Failure1_RESTBMP_p_toRESTBMP, even when there is no RestBMP selection set. If there is no valid selection set, the system generates these two feature classes with zero records (empty fc).

The issue is that these two feature classes shouldn't be generated, if there is are no records expected to be exported.

leeensminger commented 6 years ago

@gerrykelly still seems to be an issue when running the ETL for selection set 1A - whereby no records in RestBMP would be expected in the target output.

leeensminger commented 6 years ago

Just ran selection set 1B - where no BMP or BMPPOI output records would be expected, and found that an Append_Failure_RESTBMP and Append_Failure_BMP entities were exported. So this seems to be more wide spread than the title suggests.

Definitely deprioritize this issue, as its really just an appearance issue - and the use case of not having one of the selection sets is rare.

leeensminger commented 6 years ago

@gerrykelly still needs to be fixed this week if possible, but deprioritize behind the other functional issues.

gerrykelly commented 6 years ago

@leeensminger This should be fixed now

leeensminger commented 6 years ago

Looks good