kcigeospatial / balt_co_ETL

This will provide a place to track internal issues around the Baltimore County NPDES NCT application ETL.
0 stars 0 forks source link

ETL - Update ETL Translation - ETL does not report PID points or IDDE Inspections that occurred at PID Points #88

Open dhenry-KCI opened 6 years ago

dhenry-KCI commented 6 years ago

The ETL rules append Outfalls that have IDDE_INSP to the feature class MDE.OUTFALLS.

However, the ETL rules do not append PID points that have IDDE_INSP to the feature class MDE.OUTFALLS. Additionally, the ETL rules do not appear to append IDDE Inspections that occurred at PID points to the MDE.IDDE table.

Baltimore County must report IDDE Inspections that occur at PID points, at a minimum to obtain TMDL credit for IDDE eliminations that occur at those PID points.

We need the ETL to accept IDDE records that occur at PID points and append them to MDE.IDDE table.

We also need the ETL to accept PID point records and append them to MDE.OUTFALLS feature class, with default values for the following MDE fields:

DIM_OUTFALL default to -99 HT_OUTFALL default to -99 WT_OUTFALL default to -99 TYPE_OUTFL default to 'OTH' for Other TYPE_MATL default to 'OTH' for Other GEN_COMMENTS begin with "Non-outfall illicit discharge." and any MDE_COMMENTS are added after this.

gerrykelly commented 6 years ago

@dhenry-KCI So far as "ETL rules do not appear to append IDDE Inspections that occurred at PID points", right ... if you search the Excel ETL doc for PID, you won't find it and it is not in my ETL code at all so this is new. I know enough from your comments take a first shot at it, but we might need to discuss the logic for only taking the latest inspection, handling reporting year ... to fine tune it later.

gerrykelly commented 6 years ago

@dhenry-KCI Just assigning this back to you to close/remove or leave in hibernation