kciter / aws-ecr-action

This Action allows you to create Docker images and push into a ECR repository.
MIT License
146 stars 116 forks source link

fix: set defaults in entrypoint to prevent failures for images #25

Closed codfish closed 3 years ago

codfish commented 3 years ago

Fixes #22

FYI @kciter

There's an issue with GitHub Actions when relying on default inputs when using a docker image: https://github.community/t/when-using-prebuilt-image-uses-docker-inputs-not-explicitly-set-in-with-arent-sent-in-docker-run/174666

If you directly use the Docker image, there is no action.yml file to be parsed, just the Docker image. In that case you need to set any defaults within the image (e.g. in a script that reads the inputs).

This fixes the issue