search

kciter / qart.js

Generate artistic QR code. 🎨
https://kciter.github.io/qart.js/
GNU General Public License v3.0
3.15k stars 176 forks source link

use `qrcode-generator` as package dependency? #30

Open sabrinaluo opened 5 years ago

sabrinaluo commented 5 years ago

Hello, thank you for the amazing qart.

Wondering if it's possible to use https://www.npmjs.com/package/qrcode-generator as dependency rather than including qrcode.js in the bundle? or maybe expose qrcode API ?

The situation I encountered is to need both API of qart and qrcode, since qart didn't expose the qrcode API, will need to install the origin qrcode-generator. This makes the bundle size bigger than it should. :)

misteral commented 5 years ago

@sabrinaluo Hi, please welcome pull request. @kciter what u think(do we have any changes in local version) ?