search

kciter / react-barcode

A <Barcode/> component for use with React.
http://kciter.github.io/react-barcode/
ISC License
400 stars 72 forks source link

StrictMode warnings because of renderElement #42

Open kachkaev opened 4 years ago

kachkaev commented 4 years ago

👋 @kciter,

Awesome lib, I've been using it for a couple of years!

You've probably heard about the upcoming Concurrent Mode, which imposes some additional restrictions to the components. It seems that react-barcode is not fully compatible because of a string ref begin used. Here is a warning I'm seeing after wrapping <Barcode> into <React.StrictMode>:

Warning: A string ref, "renderElement", has been found within a strict mode tree.
String refs are a source of potential bugs and should be avoided. We recommend
using useRef() or createRef() instead. Learn more about using refs safely here:
https://fb.me/react-strict-mode-string-ref
iamchathu commented 3 years ago

Same here. I'm getting this on a Next.js project. Warning seems pushed from SSR.

iamchathu commented 3 years ago

I created a simple hooks based one without this warning react-jsbarcode

robert8888 commented 2 years ago

Why you don't publish this changes ? there is pr merged to master month ago and in 1.4.1 i still get this strict mode message.... When are you planning to do this ?