search

kciter / react-barcode

A <Barcode/> component for use with React.
http://kciter.github.io/react-barcode/
ISC License
396 stars 72 forks source link

Add React ^18.0.0 support #69

Closed JeffreyStevens closed 6 months ago

JeffreyStevens commented 2 years ago

Hello!

Thank you for this package. Is it possible to merge the React version pull request so we can remove the --legacy-peer-deps flag from our Azure build process? I never needed that until I added this package to our app.

Thank you.

JeffreyStevens commented 2 years ago

The new 1.4.2 version does have React 18 in it but I still get errors because I am at 18.2.0 and the merged code only allows for 18.0.0.

npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.0.0 || ^17.0.0 || 18.0.0" from react-barcode@1.4.2
npm ERR! node_modules/react-barcode
npm ERR!   react-barcode@"1.4.2" from the root project
martindebrunne commented 2 years ago

Hi ! I got the same error ;) Could you fix this issue please ?

ghost commented 2 years ago

Hello ! Same Err

kciter commented 2 years ago

1.4.5 updated. I'm sorry too late.