subroutines: fix rotation probing with pre-existing rotation offset

kcjengr / probe_basic

User interface for the LinuxCNC machine control.

https://kcjengr.github.io/probe_basic/

GNU General Public License v3.0

90 stars 58 forks source link

subroutines: fix rotation probing with pre-existing rotation offset #78

Closed sttts closed 1 year ago

sttts commented 1 year ago

The probing math is relative to workspace coordinates. The g10 l2 correctly adds the former work offsets to the calculated new origin, but it forgets the former rotation offset. This PR fixes that for all 8 corner edge probing commands.

After this PR, the measured angle should converge towards zero when repeatedly probing and setting the wco angle.

Lcvette commented 1 year ago

nicely done! I like that addition to the subroutine! have ok'd the merge should be pulled shortly! Thank you for your contribution!