search

kcjengr / probe_basic

User interface for the LinuxCNC machine control.
https://kcjengr.github.io/probe_basic/
GNU General Public License v3.0
89 stars 55 forks source link

"SPINDLE SPEED DISPLAY RPM SOURCE" setting not remembered #99

Closed dpslwk closed 9 months ago

dpslwk commented 9 months ago

On the setting page we have "Spindle speed display rpm source" section with two buttons in the spindlerpmsourcebtnGroup group

these change the page of spindle_rpm_source_widget via some python (left spindle rpm box)

Screenshot 2023-11-26 at 19 57 36

but although these are VCPSettingsPushButton's they have no settingName set and we are not remembering this state in anyway, so at launch PB always goes back to encoder rpm and not everyone has an encore or it hooked up in hal

dpslwk commented 9 months ago

Link angular jog button is disconnected

Lcvette commented 9 months ago

spindle speed is now fixed, link angular jog is not yet completed, need to look into that a bit more to see how the best way to resolve the connection would be.

Lcvette commented 9 months ago

I am going to close this issue but let open one just for the link angular jog issue to tidy up the fix list.