search

kcjengr / qtpyvcp

QtPyVCP - Qt and Python based Virtual Control Panel framework for LinuxCNC.
https://www.qtpyvcp.com
Other
88 stars 48 forks source link

Use Qt built-in icons for notification widget messages #143

Open copysent opened 1 month ago

copysent commented 1 month ago

Icons for messages do not appear in the notifications widget if the icons do not exist. This error is present when using the linuxcnc debian image. This commit changes the icons to the built-in Qt icons instead.

This code will need to be tested to verify that it works as expected.

TurBoss commented 1 month ago

Hello!

I'm goin to test it

thank you!

TurBoss commented 1 month ago

I'm seen this

imagen imagen imagen imagen

is this what you tried?

thanks

copysent commented 1 month ago

I'm seen this

imagen imagen imagen imagen

is this what you tried?

thanks

Yes and no. We have two installed OS images running a QtPyVcp custom VCP. One is Armbian and shows the icons as pictured. The other is debian (the official linuxcnc OS image) and the icons do not show in the official image. The icon files dialog-information, etc are not present in any icon theme index file present in the debian based linuxcnc installation

TurBoss commented 1 month ago

hello, have you tried running qcompile . in bot qtpyvcp and your VCP directories?

I'm taking a look if debian need qticons something to be install because my test system is a debian 12 where i took the screenshots

copysent commented 1 month ago

python3-qtpyvcp/stable,now 4.1.2 all [installed]

I am using QtPyVcp from debian's package repositories. If qcompile needs to be run, my guess is it's something a package maintainer might be interested in.

copysent commented 1 month ago

hello, have you tried running qcompile . in bot qtpyvcp and your VCP directories?

I'm taking a look if debian need qticons something to be install because my test system is a debian 12 where i took the screenshots

If you have installed the linuxcnc debian os image and then installed KDE or Gnome afterwards, that might have pulled in additional icons that aren't there by default.

TurBoss commented 1 month ago

hello, sorry for the late reply

yes, qcompile is ran by buildbot when building debs so no need to run it again