kcl-lang / flux-kcl-controller

Flux KCL Controller
https://kcl-lang.io
Apache License 2.0
23 stars 7 forks source link

[Feature] Add more Kustomization `.spec` fields to KCLRun resource #112

Closed ron1 closed 1 month ago

ron1 commented 1 month ago

Feature Request

Is your feature request related to a problem? Please describe: I'm trying to replace a set of inter-dependent Kustomization resources with KCLRun resources. In order to do so, I need KCLRun resources to support additional Kustomization .spec fields including:

Peefy commented 1 month ago

Thanks for the feedback. We will gradually inherit more from the kustomization controller because many upstream APIs are internal, so it requires some effort. It would be great if you could participate in it. ❤️

More Issues and PRs are also welcome.

Peefy commented 1 month ago

Closed by #114, #115, #116, #117, #118 and #119

It should be noted that the postbuild parameter is not implemented in these PRs because it is a unique behavior of kustomize build. For KCL, it is replaced by KCL's compilation configuration: #117

ron1 commented 1 month ago

@Peefy Thanks much for your efforts to implement this feature. Would you be able to provide an example of how kcl's compilation configuration feature can replace the Kustomization post build substitute from feature? For example, where a variable is replaced from a field in a pre-existing ConfigMap.

Peefy commented 1 month ago

@ron1

I will provide more examples and some reference documents latter.

ron1 commented 1 month ago

Thanks again!

Peefy commented 3 weeks ago

image In the flux-kcl-controller v0.5.0

We can set the argumentsReference field from ConfigMap and Secret for the option function in the KCL code.

ron1 commented 3 weeks ago

Perfect!