issues
search
kcl-lang
/
flux-kcl-controller
Flux KCL Controller
https://kcl-lang.io
Apache License 2.0
22
stars
7
forks
source link
fix: correct kclrun ArgumentReferences property name comment
#132
Closed
ron1
closed
1 month ago
ron1
commented
1 month ago
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
[ ] N
[x] Y
Fix #128
2. What is the scope of this PR (e.g. component or file name):
api/v1alpha1/kclrun_types.go
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
[x] N
[ ] Y
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other
Peefy
commented
1 month ago
Thank you! LGTM!
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
Fix #128
2. What is the scope of this PR (e.g. component or file name):
api/v1alpha1/kclrun_types.go
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: