[Enhancement] Idea KCL Plugin Build on 233+ version including Ultimate and Community Edition

kcl-lang / intellij-kcl

IntelliJ IDEA KCL Extension

https://kcl-lang.io

11 stars 11 forks source link

[Enhancement] Idea KCL Plugin Build on 233+ version including Ultimate and Community Edition #21

Closed Peefy closed 9 months ago

Peefy commented 10 months ago

[ ] Plugin Release 0.1.15 does not work on 232 Community Edition because of the deps https://github.com/kcl-lang/intellij-kcl/pull/12 in PR https://github.com/kcl-lang/intellij-kcl/pull/12

[ ] Plugin Release 0.1.5 does not work on 233+ version including Ultimate and Community Edition
[ ] LSP Features do not work on 232.2 Ultimate version

alloveras commented 9 months ago

Hello @Peefy, I tried building the plugin for pluginUntilBuild = 233.* and platformVersion = 2023.3.2 from the main branch and it seems to work. I suspect this is because the lsp dependencies that you mention on the first bullet point in the issue description are in the lsp branch.

I wonder what's the plan to resolve the build failures on the lsp branch since JetBrains seems to make it very clear that LSP support will only be available in the paid versions of their IDEs (which effectively means: no Community Edition).

Thanks in advance!

Peefy commented 9 months ago

ping @He1pa

He1pa commented 9 months ago

Hello @Peefy, I tried the plugin for pluginUntilBuild = 233.* and platformVersion = 2023.3.2 from the main branch and it seems to work. I suspect this is because the lsp dependencies that you mention on the first bullet point in the issue description are in the lsp branch.

I wonder what's the plan to resolve the build failures on the lsp branch since JetBrains seems to make it very clear that LSP support will only be available in the paid versions of their IDEs (which effectively means: no Community Edition).

Thanks in advance!

You are right, the build failure problem occurs in the lsp branch. But I have fixed this problem and published a new version plugin in IDEA Marketplace. Now it's time to close this Issue. But anyway, thank you for your support.

alloveras commented 9 months ago

Do you mind pointing me to where the new plugin version has been released?

I could not find it either in this repository releases list nor in the IntelliJ marketplace 😅?

He1pa commented 9 months ago

Do you mind pointing me to where the new plugin version has been released?

I could not find it either in this repository releases list nor in the IntelliJ marketplace 😅?

you can build it from 'lsp' branch or search it from marketplace https://plugins.jetbrains.com/plugin/23378-kcl