Reduce redundant logic - Githubissues

kcl-lang / kcl-go

KCL Go SDK

https://pkg.go.dev/kcl-lang.io/kcl-go@main

Apache License 2.0

52 stars 26 forks source link

Reduce redundant logic #315

Closed XiaoK29 closed 5 months ago

XiaoK29 commented 5 months ago

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

2. What is the scope of this PR (e.g. component or file name):

pkg/3rdparty/jsonschema/keyword.go pkg/3rdparty/jsonschema/schema.go pkg/tools/gen/template.go pkg/tools/override/override.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[x] Other

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9222289150

Details

3 of 7 (42.86%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 62.252%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/tools/override/override.go	0	4	0.0%
<!--	Total:	3	7	42.86%	-->

Totals
Change from base Build 9219325091:	0.03%
Covered Lines:	3328
Relevant Lines:	5346

💛 - Coveralls