kcl-lang / kcl

KCL Programming Language (CNCF Sandbox Project). https://kcl-lang.io
https://kcl-lang.io
Apache License 2.0
1.61k stars 113 forks source link

feat: enhance upgrade dict to schema. #1381

Closed He1pa closed 4 months ago

He1pa commented 4 months ago

handle union type of dict whichvalue is scheam

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/resolver/*

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

Peefy commented 4 months ago

CI failed on the unit tests. cc @He1pa

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9302346651

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/goto_def.rs 43 44 97.73%
kclvm/sema/src/resolver/config.rs 43 45 95.56%
kclvm/sema/src/resolver/ty.rs 36 39 92.31%
<!-- Total: 124 130 95.38% -->
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/ty.rs 2 77.05%
kclvm/tools/src/LSP/src/util.rs 46 36.83%
kclvm/tools/src/LSP/src/completion.rs 48 89.26%
<!-- Total: 96 -->
Totals Coverage Status
Change from base Build 9297926288: -0.02%
Covered Lines: 54382
Relevant Lines: 76603

💛 - Coveralls