kcl-lang / kcl

KCL Programming Language (CNCF Sandbox Project). https://kcl-lang.io
https://kcl-lang.io
Apache License 2.0
1.41k stars 110 forks source link

fix: allow setting PROTOC environment variable #1414

Closed MatisseB closed 2 weeks ago

MatisseB commented 2 weeks ago

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

fix #1413

2. What is the scope of this PR (e.g. component or file name):

kclvm/third-party/prost-wkt/wkt-types/build.rs kclvm/api/build.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

This fix ensures that if the PROTOC environment variable is already set, it will be used; otherwise, it defaults to using the protoc_bin_vendored binaries. This improves the flexibility of the protocol buffer compiler setup.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

No tests seams to be required for this change as the integration is pretty straightforward.


I have read the CLA Document and I hereby sign the CLA

github-actions[bot] commented 2 weeks ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request