kcl-lang / kcl

KCL Programming Language (CNCF Sandbox Project). https://kcl-lang.io
https://kcl-lang.io
Apache License 2.0
1.7k stars 119 forks source link

feat: enhance cycle deps error message #1639

Closed He1pa closed 2 months ago

He1pa commented 2 months ago

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Optimize the error content, report errors on all nodes in cycle , and provide cycle information image

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10860315258

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/import.rs 26 27 96.3%
kclvm/sema/src/ty/context.rs 17 18 94.44%
kclvm/sema/src/resolver/global.rs 59 61 96.72%
<!-- Total: 119 123 96.75% -->
Files with Coverage Reduction New Missed Lines %
kclvm/ast/src/pos.rs 11 68.75%
<!-- Total: 11 -->
Totals Coverage Status
Change from base Build 10859818774: 0.03%
Covered Lines: 51270
Relevant Lines: 72633

💛 - Coveralls