search

kcl-lang / krm-kcl

Kubernetes Resource Model KCL Specification and Integrations including Kubectl, Kustomize, Helm, Helmfile, Crossplane, KPT, etc.
Apache License 2.0
20 stars 13 forks source link

[Enhancement] Resources selection #53

Closed dennybaa closed 6 months ago

dennybaa commented 6 months ago

Hello @Peefy, thanks for developing such awesome stuff first of all. I've got a question...

As I can see you use KRM function spec for KCL, I'm very new to all these tech. But I can see that from the perspective of helm, kubectl or helmfile when used together with KCL the selected resources are evidently scooped to the list of applied manifests or the applied chart.

Here's the question which is more relevant to KCL operator scenorio, but generally could be useful for every plugin which uses KCLRun. Looks like KCLRun CRD could provide some sort of match labels and api type selectors to be able to selectively apply KCL function. Otherwise KCL function is applied to all resources and filtering becomes part of every and each kcl function... This seems to be an overhead and complexity, which could be diminished if there were selectors. What's your point on this issue?

Peefy commented 6 months ago

Yes. I agree. This issue is what you want? https://github.com/kcl-lang/krm-kcl/issues/13

Peefy commented 6 months ago

Hello @dennybaa Are you interested in contributing it? According to the plan, we may impl it by mid May.

Peefy commented 6 months ago

Closed by https://github.com/kcl-lang/krm-kcl/pull/54 Thanks for the great job! @shruti2522