search

kcmr / electron-theme-vscode

Electron Color Theme for Visual Studio Code
MIT License
20 stars 9 forks source link

Not working with operator mono italic font any longer #1

Closed mtin79 closed 6 years ago

mtin79 commented 6 years ago

hi there, is is my favourite theme. unfortunately it doesn't seem to support the italic operator font for ligatures any longer. any fixes or settings I need to consider?

thanks for help!

kcmr commented 6 years ago

I've removed the italics because it's more readable for me. I don't use Operator Mono anymore. You can restore that settings by adding the following to your preferences file inside "editor.tokenColorCustomizations":

"[Electron]": {
    "textMateRules": [
        {
            "scope": "entity.other.attribute-name",
            "settings": {
                "fontStyle": "italic"
            }
        },
        {
            "scope": "support.type, support.class",
            "settings": {
                "fontStyle": "italic"
            }
        }
    ]
}

Hope it helps you.

mtin79 commented 6 years ago

Amazing, thank you very much! This is the best theme ever :-)

For others and future lookups, this is what I added to my Settings to make it work with Operator Mono Italic Fonts:

  "workbench.colorTheme": "Electron",
  "editor.fontFamily": "Operator Mono",
  "editor.fontWeight": "200",
  "editor.fontSize": 12,
  "editor.tabSize": 2,
  "editor.tokenColorCustomizations": {
    "[Electron]": {
      "textMateRules": [
        {
          "scope": "entity.other.attribute-name",
          "settings": {
            "fontStyle": "italic"
          }
        },
        {
          "scope": "support.type, support.class",
          "settings": {
            "fontStyle": "italic"
          }
        }
      ]
    }
  }
kcmr commented 6 years ago

Perfect! Closing the issue.

alestry-perez commented 2 years ago

I've removed the italics because it's more readable for me. I don't use Operator Mono anymore. You can restore that settings by adding the following to your preferences file inside "editor.tokenColorCustomizations":

"[Electron]": {
    "textMateRules": [
        {
            "scope": "entity.other.attribute-name",
            "settings": {
                "fontStyle": "italic"
            }
        },
        {
            "scope": "support.type, support.class",
            "settings": {
                "fontStyle": "italic"
            }
        }
    ]
}

Hope it helps you.

This is what I've been looking for to customize some other theme for my workspace thank you! I didn't know I could do this.