search

kcoley / gltf2usd

command-line utility for converting glTF 2.0 models to USD
MIT License
263 stars 39 forks source link

Skinned mesh without skin object should be dealt as a warning #140

Closed jclarkk closed 5 years ago

jclarkk commented 5 years ago

bad_skin.zip In this example there is a Mesh which contains the JOINTS and WEIGHTS attributes yet the node linked to the mesh does not contain a link to the skin.

In the GLTF Validator this is dealt as a warning and it feels like it should be treated the same here as well rather than throwing an error since the gltf_node.get_skin() returns a NoneType.

kcoley commented 5 years ago

@jclarkk I just merged a fix for this (https://github.com/kcoley/gltf2usd/pull/141). The tool originally assumed joints on a node had a skin associated with them. Now the tool displays a warning if it cannot find a skin.

jclarkk commented 5 years ago

Awesome, thanks!