search

kconger / android-serial-gps-driver

Android Serial GPS Driver
19 stars 15 forks source link

Problem with Navilock device #3

Closed kolaci closed 5 years ago

kolaci commented 5 years ago

Hi, I am building navsat device with Navilock GPS receiver (ublox 5 chipset). This device (and probably many others) sends both type of sentences GGA and GSA in every cycle. And this is problem, because your driver sends up valid data with "fix" from the first one and zeroed invalid data with "fix" from the second one. Navigation software is confused, especially speed and altitude values are zero or incorrect.

Fixed code which works well is attached. You can "commit" it to this branch.

BTW, I split original gps.c file to two files - gps.c and nmea.c because of simpler testing of NMEA parser .

Regards, Martin Kolaci

gps-driver.zip

Martin-Kolaci commented 5 years ago

Or, you can grant me right to create branch with fix and I will commit fix to GitHub.

kconger commented 5 years ago

Hi Martin,

Thanks for the contribution, I'll take a look soon.

Thanks, Keith

On Mon, Nov 5, 2018 at 3:41 AM Martin-Kolaci notifications@github.com wrote:

Or, you can grant me right to create branch with fix and I will commit fix to GitHub.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kconger/android-serial-gps-driver/issues/3#issuecomment-435830123, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXxhlDifqS2lQSjqmjSKihvV6eKwNwgks5usBXFgaJpZM4YM-bJ .

Martin-Kolaci commented 5 years ago

Hi Keith, please give me access (if you can) to this repository. I would like to commit couple of fixes and enhancements to separate branch. Here is some folks which need it: https://forum.emteria.com/discussion/53/gps-module#latest

kconger commented 5 years ago

Hi Martin,

Sorry for the delay adding you as a collaborator now.

Martin-Kolaci commented 5 years ago

Thank you very much Keith. I pushed new branch gsa-timezone-fix+timesync to the repo and created pull request. Please could you take a look and review (if it's necessary) my changes? I tested it on the Emteria Android build (Raspberry 3b+) and it works well.

Regards, Martin Kolaci

kconger commented 5 years ago

Hi Martin,

Thanks for the enhancements. I've merged your changes.