search

kconnour / pyRT_DISORT

A Python package for helping to compute input arrays to DISORT.
https://kconnour.github.io/pyRT_DISORT/
BSD 3-Clause "New" or "Revised" License
14 stars 5 forks source link

default values in of in "Spacecraft Retrieval example #28

Open mjwolff opened 3 months ago

mjwolff commented 3 months ago

Feature request

TEMIS = 0 should be the default. This is setting the emissivity of the "upper boundary condition" (analogous to the surface), which is not something that it done in terrestrial atmosphere RT. So you want a value that is not going to create problems if someone turns on thermal emission and is not thinking to check this variable.

H_LYR variable name should be changed when you are setting the atmospheric scale height for vertical profiles. I suggest something like H or even "H_scale".

default value of H_LYR (which has dimension N+1 if there are N layers in the atmosphere) would just be the latitudes (AGL) of the layer boundaries (a.k.a. the z grid). there are only needed by DISORT when using the pseudo-spherical approximation. in the nomenclature of this example, right before the call to distort you could have a definition like so: H_LYR = altitude_grid

Priority

mainly a documentation request, but just in case some default values are set outside of the spacecraft retrieval example.

kconnour commented 3 months ago

Fixing TEMIS is easy to fix and done.

H_LYR (which has dimension N+1 if there are N layers in the atmosphere) would just be the latitudes (AGL) of the layer boundaries...

should "latitudes" be "altitudes"? If so, are the units the same as EARTH_RADIUS?

H_LYR variable name should be changed when you are setting the atmospheric scale height for vertical profiles. I suggest something like H or even "H_scale".

I'm not sure how to interpret this. It seems like I should simply set H_LYR = z_grid and not have any calls to the scale height function. If H_LYR doesn't necessarily have any relation to the scale height, it's not clear to me that the scale_height function is particularly useful to include (but it 's not hurting anything, so I can certainly keep it around).

mjwolff commented 3 months ago

Yes, altitudes (oops). I have been assuming same units. Was km the test problem.

Should probably change variable to PLANET_RADIUS

Sent from an iPhone

On Apr 3, 2024, at 14:40, kconnour @.***> wrote:



Fixing TEMIS is easy to fix and done.

H_LYR (which has dimension N+1 if there are N layers in the atmosphere) would just be the latitudes (AGL) of the layer boundaries...

should "latitudes" be "altitudes"? If so, are the units the same as EARTH_RADIUS?

H_LYR variable name should be changed when you are setting the atmospheric scale height for vertical profiles. I suggest something like H or even "H_scale".

I'm not sure how to interpret this. It seems like I should simply set H_LYR = z_grid and not have any calls to the scale height function. If H_LYR doesn't necessarily have any relation to the scale height, it's not clear to me that the scale_height function is particularly useful to include (but it 's not hurting anything, so I can certainly keep it around).

— Reply to this email directly, view it on GitHubhttps://github.com/kconnour/pyRT_DISORT/issues/28#issuecomment-2035436176, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKXHPA2JB4FERYJEDSMNTLY3RLLTAVCNFSM6AAAAABFPT4WGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZVGQZTMMJXGY. You are receiving this because you authored the thread.Message ID: @.***>

kconnour commented 3 months ago

Ok that'll be fixed momentarily. While I agree that EARTH_RADIUS sucks as a variable name, I'm sticking to using the DISORT convention and that's what they call it...

mjwolff commented 3 months ago

You mean because of f2py? You mean that you can’t override a one-to-one match with the variable name?

On Apr 4, 2024, at 16:11, kconnour @.***> wrote:

Ok that'll be fixed momentarily. While I agree that EARTH_RADIUS sucks as a variable name, I'm sticking to using the DISORT convention and that's what they call it...

— Reply to this email directly, view it on GitHub https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkconnour%2FpyRT_DISORT%2Fissues%2F28%23issuecomment-2038227982&data=05%7C02%7Cmjwolff%40spacescience.org%7C5d351316ff724774976208dc54ebc3f8%7C3461589e91624c2e8e5b764489129af6%7C1%7C0%7C638478618790398890%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=mD0EtXV2hIWLYXeRO3gYoePfOWA3A6qFmsVtm8L%2FPLU%3D&reserved=0, or unsubscribe https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAKXHPCBE3HUGWW6X4GTXLDY3W6XHAVCNFSM6AAAAABFPT4WGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZYGIZDOOJYGI&data=05%7C02%7Cmjwolff%40spacescience.org%7C5d351316ff724774976208dc54ebc3f8%7C3461589e91624c2e8e5b764489129af6%7C1%7C0%7C638478618790415900%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=mFyxbXuRh5V4UgDrKV2peqR%2BCblxWU98M2MOQDcIF%2B0%3D&reserved=0. You are receiving this because you authored the thread.

kconnour commented 3 months ago

It's not due to f2py. I'm choosing the convention to use what DISORT asks for. I figure it'd be nicer to anyone who may have DISORT experience to leave the variable names the same within this package. I could modify f2py to make it rename EARTH_RADIUS into PLANET_RADIUS if desired, but I figure that might throw off someone (potentially).

mjwolff commented 3 months ago

It doesn’t make a difference to me, but I suspect it is more confusing to a new users. However, if we create an example with pseudo-spherical geometry somewhere, then that will solve the problem. I will work on one.

On Apr 4, 2024, at 17:26, kconnour @.***> wrote:

It's not due to f2py. I'm choosing the convention to use what DISORT asks for. I figure it'd be nicer to anyone who may have DISORT experience to leave the variable names the same within this package. I could modify f2py to make it rename EARTH_RADIUS into PLANET_RADIUS if desired, but I figure that might throw off someone (potentially).

— Reply to this email directly, view it on GitHub https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkconnour%2FpyRT_DISORT%2Fissues%2F28%23issuecomment-2038351455&data=05%7C02%7Cmjwolff%40spacescience.org%7C9a60bceb634841d0cca908dc54f64541%7C3461589e91624c2e8e5b764489129af6%7C1%7C0%7C638478663920838297%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=RSLfkcvBn92qzHmz5qM7JEvY0UiWOlY2pwqKfuZx6%2Fg%3D&reserved=0, or unsubscribe https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAKXHPEEQQU4HWCAXGVJFLLY3XHRFAVCNFSM6AAAAABFPT4WGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZYGM2TCNBVGU&data=05%7C02%7Cmjwolff%40spacescience.org%7C9a60bceb634841d0cca908dc54f64541%7C3461589e91624c2e8e5b764489129af6%7C1%7C0%7C638478663920858681%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=REtJUVqaama0rF51A5Oqhje3I1a%2FXaDizcNQgc1JA0Q%3D&reserved=0. You are receiving this because you authored the thread.