search

kcp-dev / code-generator

Generators for workspace-aware clientsets, informers, and listers
Apache License 2.0
4 stars 11 forks source link

Add informergen #16

Closed njhale closed 2 years ago

njhale commented 2 years ago

Add the informer generator to generate kcp-aware wrappers for existing informers.

fabianvf commented 2 years ago

part of https://github.com/kcp-dev/kcp/issues/759

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/code-generator/blob/main/OWNERS)~~ [njhale] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
fabianvf commented 2 years ago

in getting core types to work I seem to have broken the regular api imports, need to fix that

ncdc commented 2 years ago

/hold

fabianvf commented 2 years ago

Can you add copyright headers to all new files that don't have them?

:facepalm: yep

Are any of the new files copied from other repos, or are they all our brand new code?

The templates are heavily inspired by existing informergen but not lifted directly

ncdc commented 2 years ago

/lgtm

ncdc commented 2 years ago

(My force push was just rebasing on top of main and adjusting to namer being moved to third_party. No other changes.)

ncdc commented 2 years ago

/unhold