search

kcp-dev / code-generator

Generators for workspace-aware clientsets, informers, and listers
Apache License 2.0
4 stars 11 forks source link

Add missing clientgen markers #17

Closed varshaprasad96 closed 2 years ago

varshaprasad96 commented 2 years ago

Supersedes #14

Fixes: #10

varshaprasad96 commented 2 years ago

cc: @ncdc @fabianvf @njhale The PR is ready for review. With this, the additional genclient formats are now supported. Tested this out with some upstream k8s types: For apps:v1 and certificates:v1, here is the output: https://github.com/varshaprasad96/kubernetes/tree/test-scaffolding/staging/src/k8s.io/client-go/clusterclient/typed

Unfortunately the entire k8s api don't work in one go. Digging into the upstream k8s code-gen, realized they have a patch to add plural names for the types which needs to be brought in here. I'll create an issue for that and fix it in follow up. (https://github.com/kcp-dev/code-generator/issues/19)

fabianvf commented 2 years ago

part of https://github.com/kcp-dev/kcp/issues/759

stevekuznetsov commented 2 years ago

This needs a rebase but is otherwise ready to merge, I think