search

kcp-dev / code-generator

Generators for workspace-aware clientsets, informers, and listers
Apache License 2.0
4 stars 11 forks source link

[Fix] Add plural naming formats in scaffolding #21

Closed varshaprasad96 closed 2 years ago

varshaprasad96 commented 2 years ago

This PR adds plural formats while defining interfaces which is similar to what code-gen does.

This is blocked on #17 and needs to be rebased after it is merged. Please review only the last 2 commits. It is ready for review, but blocked for merging hence converting it to draft.

Fixes: #19

varshaprasad96 commented 2 years ago

Blocked by #17

varshaprasad96 commented 2 years ago

Rebased this with master. Not sure why CI isn't getting triggered. Closing and reopening the PR.

stevekuznetsov commented 2 years ago

@varshaprasad96 looks like you still need to rebase - perhaps your local copy of master is out of date?