search

kcp-dev / code-generator

Generators for workspace-aware clientsets, informers, and listers
Apache License 2.0
4 stars 11 forks source link

fix: Add fixes for running against upstream #30

Closed varshaprasad96 closed 2 years ago

varshaprasad96 commented 2 years ago

This PR introduces 2 changes:

  1. Writing of cluserclient wrappers moved towards the end, after interface wrappers are generated. This is to consider the case, wherein the api pacakge provided by the user does not contain genclient markers at all.
  2. Revert CurrentPacakge utility, to find the go mod path of the directory passed instead of considering the abspath.

Fixes: #28 Signed-off-by: varshaprasad96 varshaprasad96@gmail.com

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianvf, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/code-generator/blob/main/OWNERS)~~ [fabianvf,varshaprasad96] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment