search

kcp-dev / code-generator

Generators for workspace-aware clientsets, informers, and listers
Apache License 2.0
4 stars 11 forks source link

Also sort groups and versions for deterministic generation #34

Closed fabianvf closed 2 years ago

ncdc commented 2 years ago

@fabianvf I guess the generated files happen to be sorted correctly already, as verify-codegen passed?

fabianvf commented 2 years ago

@ncdc yeah, I just noticed it popping up when generating the KCP informers, one of the groupInterfaces had v1beta1 followed by v1alpha1 locally but not in CI. I also don't think the api we have in there for verify-codegen is testing multiple groups/versions at the moment, I can go ahead and add more in this PR or in a followup

ncdc commented 2 years ago

Add to this one, if you have time?

fabianvf commented 2 years ago

@ncdc done

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianvf, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/code-generator/blob/main/OWNERS)~~ [fabianvf,ncdc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment