search

kcp-dev / code-generator

Generators for workspace-aware clientsets, informers, and listers
Apache License 2.0
4 stars 11 forks source link

🌱 switch to logicalcluster.v3 #74

Closed p0lyn0mial closed 1 year ago

p0lyn0mial commented 1 year ago

Summary

This PR switches the code-generator repository to use logicalcluster.v3 and also bumps the major version number for this repository to v2 in the go.mod file. That means that users will have to import it as github.com/kcp-dev/code-generator/v2

Related issue(s)

Fixes #

p0lyn0mial commented 1 year ago

do we want to create v2 for this pkg?

sttts commented 1 year ago

do we want to create v2 for this pkg?

Yes

sttts commented 1 year ago

/lgtm /approve

p0lyn0mial commented 1 year ago

fyi: i'm going to revert https://github.com/kcp-dev/code-generator/pull/74/commits/9ebb7f6fdd310472202ae527744b9fbbdec5cf16 once we merge https://github.com/kcp-dev/client-go/pull/20

stevekuznetsov commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/code-generator/blob/main/OWNERS)~~ [stevekuznetsov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment