search

kcp-dev / code-generator

Generators for workspace-aware clientsets, informers, and listers
Apache License 2.0
4 stars 11 forks source link

✨ Update to Kubernetes 1.30.0 #90

Closed embik closed 5 months ago

embik commented 5 months ago

Summary

This PR is another step towards the 1.30 rebase for kcp. I've updated all dependencies to 1.30 (and corresponding kcp-dev/apimachinery).

I reviewed the output of git diff v1.28.0 v1.30.0 -- cmd/client-gen/ cmd/informer-gen/ cmd/lister-gen/ and the only change to generated code seems to be https://github.com/kubernetes/kubernetes/commit/9c4651bd0479b84f5e5913649207476717f3f13e. I've adapted our generated informer code to also set the transform func, but I'll be honest: I'm not sure I've done this right and would appreciate a bit of scrutiny on this. I'm specifically not sure if it should have been wrapped in {{if not .useUpstreamInterfaces -}} or not.

Related issue(s)

Fixes #

Release Notes

Update to Kubernetes 1.30.0 and controller-tools 0.15.0
embik commented 5 months ago

/cc @sttts @mjudeikis

sttts commented 5 months ago

/lgtm /approve

kcp-ci-bot commented 5 months ago

LGTM label has been added.

Git tree hash: b21837d43b06d75761f1382c26b8a860b8060d58

kcp-ci-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/code-generator/blob/main/OWNERS)~~ [sttts] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment